Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: address best practices #50

Merged
merged 1 commit into from
Apr 5, 2024
Merged

fix: address best practices #50

merged 1 commit into from
Apr 5, 2024
+62 −28

Conversation

jaypaik
Copy link
Collaborator

@jaypaik jaypaik commented Apr 4, 2024 •
edited
Loading

Addressing the Adherence to Best Practices section from the audit.

  1. No code change: not addressing for event order consistency across the two accounts.
  2. No code change: not addressing since it is difficult to get the owner in the user operation flow.
  3. Removed ownerToAdd == address(0) check in MultiOwnerLightAccount._addOwnersOrRevert().
  4. Simplified owner check in MultiOwnerLightAccountFactory.createAccountSingle().
  5. EntryPoint interface ID verification on factory deployments.
  6. Removed duplicate import of SIG_VALIDATION_FAILED in BaseLightAccount.
  7. Added comments to clarify that storage versions != release versions.
  8. Narrowed function visibility in various places.

@jaypaik jaypaik requested a review from a team April 4, 2024 22:59
adam-alchemy
adam-alchemy approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@adam-alchemy adam-alchemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, addresses everything noted.

@jaypaik jaypaik force-pushed the 04-04-fix_ALC-LA2-4_revert_when_transferring_to_0_address branch 3 times, most recently from 985a246 to 680aafd Compare April 5, 2024 20:48
Base automatically changed from 04-04-fix_ALC-LA2-4_revert_when_transferring_to_0_address to develop April 5, 2024 20:51
@jaypaik jaypaik force-pushed the 04-04-fix_address_best_practices branch from f22a766 to b6cc13b Compare April 5, 2024 20:51
@jaypaik jaypaik merged commit ac34254 into develop Apr 5, 2024
2 checks passed
@jaypaik jaypaik deleted the 04-04-fix_address_best_practices branch April 5, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adam-alchemy adam-alchemy adam-alchemy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaypaik @adam-alchemy